Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TaintClusterSucceed and update TaintClusterFailed #440

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add TaintClusterSucceed and update TaintClusterFailed #440

merged 1 commit into from
Aug 7, 2023

Conversation

Affan-7
Copy link
Contributor

@Affan-7 Affan-7 commented Aug 5, 2023 •
edited
Loading

This closes #438

Added TaintClusterSucceed event to Cluster object, and merged TaintClusterByConditionFailed and RemoveTargetClusterFailed to TaintClusterFailed.

Deployment preview: https://deploy-preview-440--karmada.netlify.app/docs/next/reference/instrumentation/event

@karmada-bot
Copy link
Collaborator

Welcome @Affan-7! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2023
@Affan-7
Add TaintClusterSucceed and update TaintClusterFailed
c07cb57 
Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
@Affan-7
Copy link
Contributor Author

Affan-7 commented Aug 5, 2023

/kind documentation

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 5, 2023
Arhell
Arhell reviewed Aug 6, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2023
@Arhell Arhell removed their assignment Aug 6, 2023
RainbowMango
RainbowMango approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@karmada-bot karmada-bot merged commit e2d528a into karmada-io:main Aug 7, 2023
5 checks passed
@RainbowMango RainbowMango mentioned this pull request Aug 7, 2023
Open
@Affan-7 Affan-7 deleted the taint-events branch August 14, 2023 16:50
@Affan-7 Affan-7 mentioned this pull request Sep 20, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Poor12 Poor12 Awaiting requested review from Poor12

@Tingtal Tingtal Awaiting requested review from Tingtal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the event docs
4 participants
@Affan-7 @karmada-bot @RainbowMango @Arhell