Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karmada Highly Available Topology Overview #443

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Affan-7
Copy link
Contributor

@Affan-7 Affan-7 commented Aug 6, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:
This PR introduces an overview to HA architecture of karmada, so users get aware about Karmada HA.

Which issue(s) this PR fixes:
Related to: #418
Task 1 out of 5

Special notes for your reviewer:
@RainbowMango can you please review the architecture in this draft.
Feel free to add some suggestions. I will move forward when everything looks good to you.

Newly added page: https://deploy-preview-443--karmada.netlify.app/docs/next/installation/ha-installation/

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 6, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2023
@Affan-7
Copy link
Contributor Author

Affan-7 commented Aug 6, 2023

/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@RainbowMango
Copy link
Member

@Affan-7 , Thank you very much for doing this. That's awesome.

I think Karmada's HA Topology is quite similar to Kubernetes. So can we describe it as this document?

  • Stacked etcd topology
  • External etcd topology

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, just some nits, otherwise LGTM.

docs/installation/ha-installation.md Outdated Show resolved Hide resolved
docs/installation/ha-installation.md Outdated Show resolved Hide resolved
docs/installation/ha-installation.md Outdated Show resolved Hide resolved
docs/installation/ha-installation.md Outdated Show resolved Hide resolved
docs/installation/ha-installation.md Outdated Show resolved Hide resolved
@Affan-7 Affan-7 force-pushed the ha-topology-overview branch 2 times, most recently from 3003ddf to 5ed486d Compare August 11, 2023 05:01
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please squash your commits? Then things will be all set, thanks, well done.

By the way, which tools did you use to draw the excellent picture? Please add the source file if possible,.

Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
@Affan-7
Copy link
Contributor Author

Affan-7 commented Aug 11, 2023

Thank you for collaboration @RainbowMango, I appreciate your contributions to the open-source.

I use www.canva.com for creating diagrams and graphics. I discovered this tool while I was creating some graphics for my tech blog. It's very handy and easy to use. Here are the source files.

https://www.canva.com/design/DAFrH6RfJp4/ISaw242zbJxnH5HOUElF2g/edit?utm_content=DAFrH6RfJp4&utm_campaign=designshare&utm_medium=link2&utm_source=sharebutton

https://www.canva.com/design/DAFrH9x9WiI/JURdm-FBF0P8hlV-7vSzCw/edit?utm_content=DAFrH9x9WiI&utm_campaign=designshare&utm_medium=link2&utm_source=sharebutton

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@karmada-bot karmada-bot merged commit 96cc20f into karmada-io:main Aug 11, 2023
5 checks passed
@Affan-7 Affan-7 deleted the ha-topology-overview branch August 14, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants