-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cosign verify images doc #449
Conversation
Welcome @zishen! It looks like this is your first PR to karmada-io/website 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that images
is only one kind of artifacts, we are going to add docs for binary, charts and so on.
So, please reserve the room for them.
Maybe we can organize the content as :
# Overview
## Images
### Prerequisites
### Verify image signature
#### Verify image with cosign CLI
#### Verify image with admission controller
## Binaries
## Charts
good proposal |
ff15408
to
11217b7
Compare
Signed-off-by: Tanggui Bian <softwarebtg@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry for my late and thanks for your work! @zishen |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
doc for cosign verify images.
Which issue(s) this PR fixes:
Fixes #379 #448
Refer to karmada-io/karmada#3435
Special notes for your reviewer:
@liangyuanpeng @RainbowMango @XiShanYongYe-Chang