Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cosign verify images doc #449

Merged
merged 1 commit into from
Aug 16, 2023
Merged

add cosign verify images doc #449

merged 1 commit into from
Aug 16, 2023

Conversation

zishen
Copy link
Member

@zishen zishen commented Aug 8, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:
doc for cosign verify images.

Which issue(s) this PR fixes:
Fixes #379 #448

Refer to karmada-io/karmada#3435

Special notes for your reviewer:
@liangyuanpeng @RainbowMango @XiShanYongYe-Chang

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 8, 2023
@karmada-bot karmada-bot requested review from Poor12 and Tingtal August 8, 2023 12:39
@karmada-bot
Copy link
Collaborator

Welcome @zishen! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 8, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that images is only one kind of artifacts, we are going to add docs for binary, charts and so on.
So, please reserve the room for them.
Maybe we can organize the content as :

# Overview

## Images
### Prerequisites
### Verify image signature
#### Verify image with cosign CLI
#### Verify image with admission controller

## Binaries
## Charts

@zishen
Copy link
Member Author

zishen commented Aug 10, 2023

Note that images is only one kind of artifacts, we are going to add docs for binary, charts and so on. So, please reserve the room for them. Maybe we can organize the content as :

# Overview

## Images
### Prerequisites
### Verify image signature
#### Verify image with cosign CLI
#### Verify image with admission controller

## Binaries
## Charts

good proposal

@zishen zishen force-pushed the cosign branch 3 times, most recently from ff15408 to 11217b7 Compare August 10, 2023 09:01
Signed-off-by: Tanggui Bian <softwarebtg@163.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@karmada-bot karmada-bot merged commit 9548267 into karmada-io:main Aug 16, 2023
@liangyuanpeng
Copy link

Sorry for my late and thanks for your work! @zishen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc for introduce to verify signed karmada artifacts
4 participants