Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(windows): Kill electron subprocess when main process exits. #56

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

emily-curry
Copy link
Contributor

On Windows, the current behavior is that when killing the electron-snowpack dev process, the electron process spawned by execa does not exit, and is left running indefinitely. This is documented in this issue: sindresorhus/execa#433

This fix copies the change which was applied to snowpack's plugin-build-script and plugin-run-script packages in FredKSchott/snowpack#1022.

@karolis-sh karolis-sh merged commit ed78864 into karolis-sh:main Jul 19, 2021
@karolis-sh
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants