Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix allocation of scaling factors #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moritztng
Copy link

allocate only one scaling factor per group

@karpathy
Copy link
Owner

huh. i'm only doing a quick skim atm. did i mess up the sizing of this oops

@moritztng
Copy link
Author

you allocate dim elements for the quants and also dim elements for the scaling factors. but there are only dim / gs scaling factors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants