fix(allied_express_local): shipment cancellation response parsing

karrioapi · Feb 23, 2024 · a8e1328 · a8e1328
1 parent 535de06
commit a8e1328
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/modules/connectors/allied_express_local/karrio/providers/allied_express_local/error.py b/modules/connectors/allied_express_local/karrio/providers/allied_express_local/error.py
@@ -17,8 +17,14 @@ def parse_error_response(
         errors.append(
             [
                 "400",
-                response.data["result"].get("statusError")
-                or response.data["result"].get("errors"),
+                (
+                    (
+                        response.data["result"].get("statusError")
+                        or response.data["result"].get("errors")
+                    )
+                    if isinstance(response.data["result"], dict)
+                    else response.data["result"]
+                ),
             ]
         )
 

diff --git a/.../connectors/allied_express_local/karrio/providers/allied_express_local/shipment/cancel.py b/.../connectors/allied_express_local/karrio/providers/allied_express_local/shipment/cancel.py
@@ -14,7 +14,7 @@ def parse_shipment_cancel_response(
 ) -> typing.Tuple[models.ConfirmationDetails, typing.List[models.Message]]:
     response = _response.deserialize()
     messages = error.parse_error_response(response, settings)
-    success = not response.is_error and (response.data.get("result")) == "0"
+    success = not response.is_error  # and (response.data.get("result")) == "0"
 
     confirmation = (
         models.ConfirmationDetails(