feat: Add minimal webhook back off retries similar to Stripe

karrioapi · Dec 17, 2024 · c75a6db · c75a6db
1 parent 95414d2
commit c75a6db
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/.env b/.env
@@ -16,7 +16,7 @@ OIDC_RSA_PRIVATE_KEY="-----BEGIN RSA PRIVATE KEY-----\nMIIJKQIBAAKCAgEA92+93Tyg6
 
 # Worker config
 # WORKER_IMMEDIATE_MODE=True
-TRACKING_PULSE=120
+TRACKING_PULSE=1200
 
 ## Email auth
 # EMAIL_PORT=1025

diff --git a/modules/events/karrio/server/events/task_definitions/base/__init__.py b/modules/events/karrio/server/events/task_definitions/base/__init__.py
@@ -27,15 +27,17 @@ def _run(**kwargs):
     _run()
 
 
-@db_task()
+@db_task(retries=5, retry_delay=60)
 @utils.tenant_aware
 def notify_webhooks(*args, **kwargs):
-    from karrio.server.events.task_definitions.base import webhook
+    try:
+        from karrio.server.events.task_definitions.base import webhook
 
-    utils.failsafe(
-        lambda: webhook.notify_webhook_subscribers(*args, **kwargs),
-        "An error occured during webhook notification: $error",
-    )
+        webhook.notify_webhook_subscribers(*args, **kwargs)
+
+    except Exception as e:
+        logger.error(f"An error occured during webhook notification: {e}")
+        raise e
 
 
 @db_periodic_task(crontab(hour=f"*/{DATA_ARCHIVING_SCHEDULE}"))
@@ -54,6 +56,7 @@ def _run(**kwargs):
 
     _run()
 
+
 TASK_DEFINITIONS = [
     background_trackers_update,
     periodic_data_archiving,