Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[carrier-integration] Deutsche Post #512

Merged
merged 4 commits into from
Feb 4, 2024
Merged

[carrier-integration] Deutsche Post #512

merged 4 commits into from
Feb 4, 2024

Conversation

danh91
Copy link
Member

@danh91 danh91 commented Feb 3, 2024 •
edited
Loading

  • feat: setup deutschepost extension as dpdhl API upgrade

@danh91 danh91 added carrier integration Purplship Carrier Integration related issues epic Issues that require planning and more research labels Feb 3, 2024
@danh91 danh91 linked an issue Feb 3, 2024 that may be closed by this pull request
[carrier-integration] Upgrade outdated DPDHL integration #417
Closed
@ghost
Copy link

ghost commented Feb 3, 2024 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@danh91 danh91 force-pushed the deutshe-post-upgrade branch from 5a4680b to 723d369 Compare February 4, 2024 09:11
@danh91 danh91 merged commit 2ba79bc into main Feb 4, 2024
8 of 9 checks passed
@danh91 danh91 deleted the deutshe-post-upgrade branch February 4, 2024 09:34
@MarcoWel
Copy link

MarcoWel commented Feb 4, 2024

Awesome! Only suggestion is to change name from deutschepost to dhl_de, dhl_parcel_de or similar. This API is for DHL Parcel Germany and called DHL Parcel DE Shipping by DHL themselves. Only the service "DHL Warenpost" is handled on the Deutsche Post network (while still being offered as a DHL service) - so deutschepost would be misleading to users.

@danh91
Copy link
Member Author

danh91 commented Feb 4, 2024

Awesome! Only suggestion is to change name from deutschepost to dhl_de, dhl_parcel_de or similar. This API is for DHL Parcel Germany and called DHL Parcel DE Shipping by DHL themselves. Only the service "DHL Warenpost" is handled on the Deutsche Post network (while still being offered as a DHL service) - so deutschepost would be misleading to users.

I completely agree 👍🏿. I will hotfix it since it hasn't been released yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
carrier integration Purplship Carrier Integration related issues epic Issues that require planning and more research
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[carrier-integration] Upgrade outdated DPDHL integration
2 participants
@danh91 @MarcoWel