Fix shipment identifier assignment in create shipment #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change corrects the assignment of the shipment identifier to use `info.shipment_id` instead of `info.tracking_pin`. This ensures that the shipment identifier is correctly set, allowing proper tracking and management of shipments.
danh91
approved these changes
Sep 12, 2024
| @@ -49,7 +49,7 @@ def _extract_shipment( | |||
| carrier_name=settings.carrier_name, | |||
| carrier_id=settings.carrier_id, | |||
| tracking_number=info.tracking_pin, | |||
| shipment_identifier=info.tracking_pin, | |||
| shipment_identifier=info.shipment_id, | |||
There was a problem hiding this comment.
Shame on me for this 🤦🏿♂️. I was pretty sure this was using thee shipment_id 🤔.
Thanks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects the assignment of the shipment identifier to use
info.shipment_idinstead ofinfo.tracking_pin. This ensures that the shipment identifier is correctly set, allowing to cancel or refund of shipments.