-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tracking option to extend matomo config #2
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR. Can you please document an option equivalent to |
Sure, I've added it to the readme. |
Sorry for the delay, just got to it. Original behavior, you can check it here: This PR - the behavior is not the same, which leads Matomo to get blocked by brave or adblock
|
_paq.push(['trackPageView']); | ||
_paq.push(['enableLinkTracking']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, is this PR still in development? I would need this change too.
Also not sure why this shouldn't work or be different from the current state. Maybe the order of the element creates the problem? My guide mentioned that my option should be added at the beginning for example.
So maybe we could make the following changes and add everything to the config? That way everyone can specify the order of elements like this in the config
matomo: {
matomoUrl: 'https://vega.dev.trackmage.com/',
siteId: '2',
phpLoader: 'mm.php',
jsLoader: 'mjs.php',
tracking: [
['setRequestMethod', 'POST'],
['trackPageView'],
['enableLinkTracking']
['enableHeartBeatTimer'],
]
},
_paq.push(['trackPageView']); | |
_paq.push(['enableLinkTracking']); |
Added a way to extend the plugin configuration so that other Matomo options can be used.
Also, removed
'enableHeartBeatTimer
andsetRequestMethod
from the default configs - these can be added if needed.See README.md changes for usage.