Skip to content

Commit

Permalink
Updates to release v1.7.8 fixes #166
Browse files Browse the repository at this point in the history
  • Loading branch information
kartik-v committed Sep 23, 2018
1 parent ee2ca30 commit 443949e
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
6 changes: 6 additions & 0 deletions CHANGE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
Change Log: `yii2-detail-view`
==============================

## Version 1.7.8

**Date:** 23-Sep-2018

- (enh #166): Refactor code to implement `kartik\base\BootstrapInterface`.

## Version 1.7.7

**Date:** 11-Sep-2018
Expand Down
9 changes: 5 additions & 4 deletions src/DetailView.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
* @package yii2-detail-view
* @author Kartik Visweswaran <kartikv2@gmail.com>
* @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2014 - 2018
* @version 1.7.7
* @version 1.7.8
*/

namespace kartik\detail;

use Closure;
use kartik\base\BootstrapInterface;
use kartik\base\Config;
use kartik\base\TranslationTrait;
use kartik\base\WidgetTrait;
Expand Down Expand Up @@ -57,7 +58,7 @@
* @author Kartik Visweswaran <kartikv2@gmail.com>
* @since 1.0
*/
class DetailView extends YiiDetailView
class DetailView extends YiiDetailView implements BootstrapInterface
{
use WidgetTrait;
use TranslationTrait;
Expand Down Expand Up @@ -530,7 +531,7 @@ class DetailView extends YiiDetailView
* - inputType: string|Closure, the HTML 5 input type if `type` is set to [[DetailView::::INPUT_HTML 5]].
* - inputContainer: array|Closure, HTML attributes for the input container
* - inputWidth: string|Closure, the width of the container holding the input, should be appended along with the
* width unit (`px` or `%`) - this property is deprecated since v1.7.7
* width unit (`px` or `%`) - this property is deprecated since v1.7.8
* - fieldConfig: array|Closure, optional, the Active field configuration.
* - options: array|Closure, optional, the HTML attributes for the input.
* - updateAttr: string|Closure, optional, the name of the attribute to be updated, when in edit mode. This will
Expand Down Expand Up @@ -1135,7 +1136,7 @@ protected function renderFormAttribute($config)
$inputWidth = ArrayHelper::getValue($config, 'inputWidth', '');
$container = ArrayHelper::getValue($config, 'inputContainer', []);
if ($inputWidth != '') {
Html::addCssStyle($container, "width: {$inputWidth}"); // deprecated since v1.7.7
Html::addCssStyle($container, "width: {$inputWidth}"); // deprecated since v1.7.8
}
$template = ArrayHelper::getValue($fieldConfig, 'template', "{input}\n{error}\n{hint}");
$row = Html::tag('div', $template, $container);
Expand Down
2 changes: 1 addition & 1 deletion src/DetailViewAsset.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* @package yii2-detail-view
* @author Kartik Visweswaran <kartikv2@gmail.com>
* @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2014 - 2018
* @version 1.7.7
* @version 1.7.8
*/

namespace kartik\detail;
Expand Down
1 change: 0 additions & 1 deletion src/assets/css/kv-detail-view.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
* For more JQuery plugins visit http://plugins.krajee.com
* For more Yii related demos visit http://demos.krajee.com
*/

.kv-container-bs4 .table {
margin: 0;
}
Expand Down

0 comments on commit 443949e

Please sign in to comment.