Harmonized asset namespace to allow asset compression without errors #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you compress your assets you get an `yii\base\InvalidConfigException` beacause of `kartik\dialog\DialogBootstrapAsset` and `kartik\grid\GridViewAsset`. `kartik\dialog\DialogBoostrapAsset` depends on `kartik\dialog\DialogAsset` like this:
```php
$this->depends = array_merge(['kartik\dialog\DialogAsset'], $this->depends);
```
and `kartik\grid\GridViewAsset` like this:
```php
$this->depends = array_merge(["\\kartik\\dialog\\DialogAsset"], $this->depends);
```
This results in a double asset load loop and produces the following error
> Invalid Configuration – yii\base\InvalidConfigException
An asset bundle that depends on 'all' has a higher javascript file position configured than 'all'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you compress your assets you get an
yii\base\InvalidConfigExceptionbeacause ofkartik\dialog\DialogBootstrapAssetandkartik\grid\GridViewAsset.kartik\dialog\DialogBoostrapAssetdepends onkartik\dialog\DialogAssetlike this:and
kartik\grid\GridViewAssetlike this:This results in a double asset load loop and produces the following error
Scope
This pull request includes a
Changes
The following changes were made (this change is also documented in the change log):
Related Issues
If this is related to an existing ticket, include a link to it as well.