Implement itemsLabelAccusative and message token items-acc
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, still missed one thing. These terrible German cases... It has to be "Einträgen" in line 68 and "Einträge" in line 80.
|
You have changed it in the wrong place. Please edit these separate item labels here from Line 86 to 89 |
|
Hey,
lines 86 to 90 are correct when they are used in line 80 (in German this is the nominative case). Yes, it has to be "Einträge" which is the most usual form. But in line 68 the accusative case is needed, which has to be "Einträgen" (no matter if it's items, items-few or items-many). The alternative of changing line 68 could be to implement another variable "items-acc" but this would only be useful in German, don't you think? Sometimes German is a terrible language...
Gesendet: Samstag, 23. Februar 2019 um 19:10 Uhr
Von: "Kartik Visweswaran" <notifications@github.com>
An: kartik-v/yii2-grid <yii2-grid@noreply.github.com>
Cc: ThomiLee <thomilee@web.de>, Author <author@noreply.github.com>
Betreff: Re: [kartik-v/yii2-grid] Update kvgrid.php (#879)
You have changed it in the wrong place. Please edit these separate item labels here from 86 to 90
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I will try to see if it can be enhanced. |
kartik-v
changed the title
itemsLabelAccusative and message token items-acc
kartik-v
added a commit
that referenced
this pull request
Mar 12, 2019
kartik-v
added a commit
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I still missed one thing. These terrible German cases... It has to be "Einträgen" in line 68 and "Einträge" in line 80.
Scope
This pull request includes a
Related Issues
#878