Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections error enter key when using the widget with GridView. #11

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Conversation

kevocde
Copy link
Contributor

@kevocde kevocde commented Dec 6, 2018

The widget has been modified to intercept the keydown event and thus be able to alter the value entered also in the hidden input, in this way the error is solved by pressing the "enter" key and the entered value is not preserved when used as filter in the GridView widget.

Scope

This pull request includes a

  • Bug fix
  • New feature
  • Translation

Changes

The following changes were made (this change is also documented in the change log):

  • The keydown event was added when the widget was initialized
  • It has been validated that when the decimal separator is not "." when initializing this replace in the display input the "." with the indicated decimal point.
  • The version has been increased according to the semantic versioning specification

Related Issues

#10

The widget has been modified to intercept the keydown event and thus be able to alter the value entered also in the hidden input, in this way the error is solved by pressing the "enter" key and the entered value is not preserved when used as filter in the GridView widget.
@kartik-v kartik-v added the bug Something isn't working label Dec 6, 2018
@kartik-v kartik-v merged commit 0459c54 into kartik-v:master Dec 6, 2018
kartik-v added a commit that referenced this pull request Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants