Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid data #147

Merged
merged 11 commits into from
Sep 10, 2024
Merged

Add grid data #147

merged 11 commits into from
Sep 10, 2024

Conversation

meomancer
Copy link
Collaborator

@meomancer meomancer commented Sep 10, 2024

This will fix #138

With grid system, it will just generate spw 5 times (call to tio 10 times)
Selection_029

@meomancer meomancer marked this pull request as draft September 10, 2024 04:12
Copy link

github-actions bot commented Sep 10, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
6986 6604 95% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 227e0a1 by action🐍

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 95.04950% with 15 lines in your changes missing coverage. Please review.

Project coverage is 94.49%. Comparing base (05471ef) to head (227e0a1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
django_project/gap/ingestor/grid.py 89.09% 6 Missing ⚠️
django_project/gap/admin/farm.py 60.00% 2 Missing ⚠️
django_project/gap/admin/grid.py 77.77% 2 Missing ⚠️
django_project/gap/utils/reader.py 81.81% 2 Missing ⚠️
django_project/spw/generator/crop_insight.py 92.30% 2 Missing ⚠️
django_project/gap/providers/tio.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   94.47%   94.49%   +0.02%     
==========================================
  Files         116      122       +6     
  Lines        6496     6774     +278     
==========================================
+ Hits         6137     6401     +264     
- Misses        359      373      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meomancer meomancer marked this pull request as ready for review September 10, 2024 08:26
Copy link
Collaborator

@danangmassandy danangmassandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, API calls are reduced significantly!

@danangmassandy danangmassandy merged commit c4894fa into main Sep 10, 2024
4 checks passed
@meomancer meomancer deleted the 138-grid-pixel branch September 11, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query via grid pixel instead of per farm
2 participants