Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat SPW model integration #22

Merged
merged 21 commits into from
Jul 22, 2024
Merged

Feat SPW model integration #22

merged 21 commits into from
Jul 22, 2024

Conversation

danangmassandy
Copy link
Collaborator

@danangmassandy danangmassandy commented Jul 8, 2024

This is for #20.

TODO:

  • Consume Tomorrow.io APIs to generate csv input
  • Clarify the logic with John
  • Change the data source to not using Tomorrow.io APIs (For this revision, we will still using Tomorrow.io API)

Note: For long term normals data, it's confirmed that we are going to use Tomorrow.io API first until John is okay to use the 10year data from CBAM.

Copy link

github-actions bot commented Jul 11, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2853 2718 95% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 0df1730 by action🐍

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 94.69240% with 44 lines in your changes missing coverage. Please review.

Project coverage is 95.40%. Comparing base (fe1db70) to head (0df1730).

Files Patch % Lines
django_project/spw/utils/plumber.py 89.90% 11 Missing ⚠️
django_project/gap/providers/tio.py 95.10% 7 Missing ⚠️
django_project/spw/tasks.py 46.15% 7 Missing ⚠️
django_project/spw/utils/process.py 79.31% 6 Missing ⚠️
django_project/spw/models.py 90.19% 5 Missing ⚠️
django_project/gap/utils/reader.py 80.00% 4 Missing ⚠️
django_project/spw/admin.py 88.88% 2 Missing ⚠️
django_project/gap/providers/__init__.py 66.66% 1 Missing ⚠️
django_project/spw/generator.py 98.92% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   95.53%   95.40%   -0.13%     
==========================================
  Files          48       61      +13     
  Lines        1924     2744     +820     
==========================================
+ Hits         1838     2618     +780     
- Misses         86      126      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danangmassandy danangmassandy marked this pull request as ready for review July 20, 2024 17:30
@danangmassandy danangmassandy merged commit 3463957 into main Jul 22, 2024
4 checks passed
@danangmassandy danangmassandy deleted the feat-spw branch July 22, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant