Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check plan has changes before apply #2

Merged
merged 14 commits into from
Jul 14, 2022
Merged

Conversation

eliihen
Copy link
Contributor

@eliihen eliihen commented Jul 14, 2022

Merging this PR will do two things:

  1. Apply will no longer run if the previous plan step identified no changes
  2. Adds a deploy_on input to override the branch that is used for deplying. It also makes testing of deploy easier on other branches

terraform_wrapper is now required as we read the exitcode output set by the wrapper script. On-prem runners do not have node which the script requires so we install that too.

@eliihen eliihen requested a review from a team as a code owner July 14, 2022 11:30
@eliihen eliihen requested review from lislei, felhal and berg-thom July 14, 2022 11:30
@eliihen
Copy link
Contributor Author

eliihen commented Jul 14, 2022

Verifisert oppførsel på IAM branch.

Uten endringer

bilde
https://github.com/kartverket/iam/runs/7338888007

Med endringer

bilde
Startet men cancelled så vi ikke deploya tullet jeg testa med til clusteret
https://github.com/kartverket/iam/runs/7338753400

@eliihen eliihen requested a review from odasko July 14, 2022 11:41
@eliihen eliihen changed the title Verify plan includes changes before apply Check plan has changes before apply Jul 14, 2022
@eliihen eliihen merged commit 09e1109 into main Jul 14, 2022
@eliihen eliihen deleted the verify-changed-before-apply branch July 14, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants