Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIP-504 Use plan from plan step in apply #3

Merged
merged 7 commits into from
Jul 15, 2022
Merged

SKIP-504 Use plan from plan step in apply #3

merged 7 commits into from
Jul 15, 2022

Conversation

eliihen
Copy link
Contributor

@eliihen eliihen commented Jul 15, 2022 •
edited
Loading

This avoids the apply step running a completely different plan than we can audit in the plan step

Verified behavior in IAM branch: https://github.com/kartverket/iam/pull/82

bilde

Closes SKIP-504

@eliihen eliihen marked this pull request as ready for review July 15, 2022 12:53
@eliihen eliihen requested a review from a team as a code owner July 15, 2022 12:53
@eliihen eliihen requested review from lislei, felhal and odasko July 15, 2022 12:53
@eliihen eliihen merged commit 7ee0d1a into main Jul 15, 2022
@eliihen eliihen deleted the use-plan-in-apply branch July 15, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felhal felhal felhal approved these changes

@lislei lislei Awaiting requested review from lislei lislei is a code owner automatically assigned from kartverket/skip

@odasko odasko Awaiting requested review from odasko odasko is a code owner automatically assigned from kartverket/skip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliihen @felhal