Bump to Go 1.23

[evenh]

Pending kyverno/chainsaw#1869

Summary by CodeRabbit

• New Features

  • Upgraded the Go version to 1.23.1 across multiple workflows and configuration files, introducing potential performance improvements and new features.

• Bug Fixes

  • Updated various dependencies to their latest versions, enhancing compatibility and security.

• Chores

  • General maintenance performed on the project to ensure alignment with the latest library improvements and optimizations.

• Improvements

  • Enhanced permissions for the skiperator role, allowing for more comprehensive management of Kubernetes resources.
  • Changed the execution behavior of an access policy to sequential processing, potentially affecting performance and resource utilization.

[coderabbitai]

Warning

Rate limit exceeded

@evenh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 28 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 851cf6c and 15629e0.

Walkthrough

The pull request introduces an upgrade to the Go programming language version across multiple GitHub Actions workflow files and the Dockerfile. The Go version has been updated from 1.22.2 to 1.23.1, which may include various improvements and optimizations. Additionally, the go.mod file has been updated to reflect the new Go version, along with several dependency upgrades to their latest versions, ensuring the project remains current with library improvements. Minor updates to Kubernetes Custom Resource Definitions (CRDs) and role permissions are also included, along with a modification to an access policy configuration.

Changes

Files	Change Summary
.github/workflows/*.yaml, Dockerfile	Updated Go version from 1.22.2 to 1.23.1 in workflow configurations and Dockerfile.
go.mod	Updated Go version from 1.22.2 to 1.23.1 and several dependencies to their latest versions.
config/crd/*.yaml	Updated controller-gen version from v0.16.1 to v0.16.2 in CRD metadata annotations.
config/rbac/role.yaml	Added new permissions for managing various Kubernetes resources in the skiperator ClusterRole.
tests/application/cloudsql-auth-proxy/*.yaml	Removed enabled property from cloudSqlProxy settings, simplifying the configuration.
tests/application/access-policy/*.yaml	Modified concurrent attribute from true to false in chainsaw-test.yaml, disabling concurrent execution.

Possibly related PRs

• Remove enabled field from cloudSqlProxy #517: This PR involves removing the enabled field from the CloudSQLProxySettings, related to the overall configuration management of the application, similar to the updates made in the main PR.
• Add AccessPolicies status #524: This PR adds a new field accessPolicies to various resource definitions, enhancing management of access policies, which aligns with the main PR's focus on configuration updates.
• fix bug where access policy would stop adding ports if app doesn't ex… #526: This PR addresses a bug related to access policies, relevant as it deals with functionality that could be affected by the Go version update in the main PR.

Poem

🐰 In the meadow, hops a little hare,
With a code update, we dance in the air!
Go's new version, oh what a delight,
Dependencies fresh, everything feels right!
Hooray for the changes, let’s give a cheer,
For a smoother build, we have nothing to fear! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fd5751f and 1b4c7d3.

Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

Files selected for processing (6)

• .github/workflows/build-and-deploy.yaml (1 hunks)
• .github/workflows/deploy-sandbox-dispatch.yaml (1 hunks)
• .github/workflows/release-version.yaml (1 hunks)
• .github/workflows/test.yml (1 hunks)
• Dockerfile (1 hunks)
• go.mod (8 hunks)

Files skipped from review due to trivial changes (4)

• .github/workflows/build-and-deploy.yaml
• .github/workflows/release-version.yaml
• .github/workflows/test.yml
• go.mod

Additional comments not posted (2)

Dockerfile (1)

1-1: Approved: Dockerfile updated to Go 1.23.

The change to update the Go version in the Dockerfile is approved. Ensure to verify the build process and application behavior with the new Go version to catch any potential compatibility issues early.

Run the following script to verify the build process:

.github/workflows/deploy-sandbox-dispatch.yaml (1)

33-33: Approved: Updated Go version in GitHub Actions workflow.

The update to Go 1.23.1 in the GitHub Actions workflow is approved. Ensure to verify the workflow execution to catch any potential compatibility issues with the new Go version.

Run the following script to verify the workflow execution:

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

config/rbac/role.yaml (1)

7-38: Approve the addition of new permissions but recommend a security review.

The new permissions added to the ClusterRole skiperator significantly expand its capabilities, allowing it to manage a wider range of Kubernetes resources. While these changes are approved, it is recommended to conduct a thorough security review to ensure that the permissions are necessary and do not expose the system to potential security risks.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1b4c7d3 and 9f5e98d.

Files selected for processing (7)

• config/crd/skiperator.kartverket.no_applications.yaml (1 hunks)
• config/crd/skiperator.kartverket.no_routings.yaml (1 hunks)
• config/crd/skiperator.kartverket.no_skipjobs.yaml (1 hunks)
• config/rbac/role.yaml (2 hunks)
• tests/application/access-policy/multiple-ns-same-label-assert.yaml (1 hunks)
• tests/application/cloudsql-auth-proxy/application-no-cloudsql-patch.yaml (1 hunks)
• tests/application/cloudsql-auth-proxy/application.yaml (1 hunks)

Files skipped from review due to trivial changes (4)

• config/crd/skiperator.kartverket.no_applications.yaml
• config/crd/skiperator.kartverket.no_routings.yaml
• config/crd/skiperator.kartverket.no_skipjobs.yaml
• tests/application/access-policy/multiple-ns-same-label-assert.yaml

Additional comments not posted (2)

tests/application/cloudsql-auth-proxy/application-no-cloudsql-patch.yaml (1)

Line range hint 1-10: Verify the default behavior of Cloud SQL Proxy after removing the enabled property.

The removal of the enabled property from the cloudSqlProxy configuration simplifies the setup but could alter how the application connects to Google Cloud SQL. It's crucial to verify whether this change disables the proxy by default or if other settings within the application or environment override this behavior.

tests/application/cloudsql-auth-proxy/application.yaml (1)

Line range hint 1-10: Verify the default behavior of Cloud SQL Proxy after removing the enabled property.

The removal of the enabled property from the cloudSqlProxy configuration could potentially disable the proxy by default or alter its enabling mechanism. It is essential to verify the new default behavior to ensure that the application's connectivity to the Cloud SQL instance is not adversely affected.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9f5e98d and 851cf6c.

Files selected for processing (1)

• tests/application/access-policy/chainsaw-test.yaml (1 hunks)

Additional comments not posted (1)

tests/application/access-policy/chainsaw-test.yaml (1)

7-7: Confirm the change to sequential execution.

The modification from concurrent: true to concurrent: false changes the execution behavior of the access policy to be sequential. This change can significantly impact performance and resource utilization, especially in environments where parallel processing is critical.

Please ensure that this change aligns with the intended behavior and verify its impact on the system. Consider running performance benchmarks or simulations to assess the effects of disabling concurrent processing.