Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV; CI: re-enable windows tests; add beta toolchain tests #179

Merged
merged 4 commits into from
Mar 31, 2021

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Mar 31, 2021

No description provided.

@dhardy
Copy link
Collaborator Author

dhardy commented Mar 31, 2021

Stable build fails: cycle detected:

error[E0391]: cycle detected when computing the bounds for type parameter `V`
  --> src/widget/view/single_view.rs:31:15
   |
31 |     V: Driver<T::Item> = driver::Default,
   |               ^^^^^^^
   |
note: ...which requires computing the bounds for type parameter `T`...
  --> src/widget/view/single_view.rs:30:38
   |
30 |     T: SingleData + UpdatableAll<(), V::Msg> + 'static,
   |                                      ^^^^^^
   = note: ...which again requires computing the bounds for type parameter `V`, completing the cycle
note: cycle used when computing the bounds for type parameter `V`
  --> src/widget/view/single_view.rs:31:5
   |
31 |     V: Driver<T::Item> = driver::Default,
   |     ^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0391`.
error: could not compile `kas`

I believe this affects all three view widgets. While it can be worked around by factoring out either V::Msg or T::Item as its own parameter, it appears that the next Rust release (current beta) can already support this, so I prefer to instead target 1.52.0.

@dhardy dhardy merged commit 06b1ae7 into master Mar 31, 2021
@dhardy dhardy changed the title CI: re-enable windows tests; add stable toolchain tests CI: re-enable windows tests; add beta toolchain tests Mar 31, 2021
@dhardy dhardy changed the title CI: re-enable windows tests; add beta toolchain tests Update MSRV; CI: re-enable windows tests; add beta toolchain tests Mar 31, 2021
@dhardy dhardy mentioned this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant