Fontdue rasterizer and other font adjustments #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That test works for me (also on the latest nightly) and the error message is incomprehensible. I'll ignore for now. |
This was referenced Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvments to text rendering, plus font raster configuration (under theme configuration).
Enables usage of the https://github.com/mooman219/fontdue rasterizer. Subjectively it may be a little better but still isn't perfect and noticably slows down start-up time.
Another option is to align to the horizontal side bearing using
ab_glyph. In some ways this is better than sub-pixel alignment, in some ways not. Either way it's not close to grid fitting.The biggest improvement to rendering was one of the simplest changes: vertically aligning text lines to the pixel grid during layout (in
kas-text). This is enabled by default; other options (including sub-pixel positioning) are now disabled by default which seems to be the best general solution.