Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CellCollection for use by Grid #443

Merged
merged 11 commits into from
Feb 23, 2024
Merged

Add CellCollection for use by Grid #443

merged 11 commits into from
Feb 23, 2024

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Feb 22, 2024

  • Rename GridChildInfoGridCellInfo
  • Add trait CellCollection, macro cell_collection!
  • Some fixes

@dhardy
Copy link
Collaborator Author

dhardy commented Feb 22, 2024

This fits with other recent changes. Unfortunately, this particular change doesn't achieve much:

  • It enables usage of kas::widgets::Grid with varying child widget types, however in this case cells cannot be added/removed and thus the existing grid! macro could be used
  • The grid! macro could, when used as a stand-alone macro, be replaced by Grid::new(cell_collection![..]). However, when used as part of the layout of a custom widget, it cannot be.

@dhardy dhardy merged commit 4f37071 into master Feb 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant