Split Layout::find_id, renaming to probe, try_probe #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: set rect in List::l_set_rect Tweak: Splitter: debug_assert that size_solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods differ slightly:
fn Layout::try_probe(coord) -> Option<Id>is auto-generated, returningNonewhen!self.rect().contains(coord)otherwise callingself.probe(coord)fn Layout::probe(coord) -> Idis customizable, returning either the result oftry_probeon a child orself.id()The former should not be customized (enforced by
#[widget]macro). It is intended that onlytry_probegets called, though there's no real issue with callingprobe.This change allows cleaner documentation and smaller implementations in user-defined widgets as well as enforcing that the method does not return
Nonewhenself.rect().contains(coord).