Any, Menu, MenuBar improvements #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Any bound requires the latter bound. Note that without this bound, using a Msg with 'a could be possible but would require parametrising Msg over 'a; the latter requires GATs (unstable). Probably this would be more complex than useful.
This makes Event::OpenPopup and ClosePopup obsolete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restricts
Widget: Anyand adds some methods around this. This functionality is not currently used, but seems worth having. As a side-effect, this requires thatWidget::Msg: 'static. As the commit notes, message types with lifetime restrictions might otherwise have been feasible, but likely wouldn't be used much and would increase complexity and add another requirement on nightly Rust.This also adds a Menu trait and uses it to improve menu behaviour, fixing #96. This allows
Event::OpenPopupandClosePopupto be removed. As noted in #96, having to use a separate menu trait seems unfortunate, but isn't that big a deal. Some alternatives I decided against:Widgettrait over an extension trait, and addfn as_extension_mutSubMenu(this would prevent custom sub-menus)