Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fenl types in Collection #494

Open
14 of 37 tasks
jordanrfrazier opened this issue Jul 10, 2023 · 1 comment
Open
14 of 37 tasks

feat: support fenl types in Collection #494

jordanrfrazier opened this issue Jul 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jordanrfrazier
Copy link
Collaborator

jordanrfrazier commented Jul 10, 2023

FenlType::Collection currently only supports type variables, meaning we can't do map<i32, V> type signatures. We should refactor the Collection type to accept FenlTypes instead of just type vars, then clean up the parsing and inference code around that.

Tasks:

@jordanrfrazier jordanrfrazier added the enhancement New feature or request label Jul 10, 2023
github-merge-queue bot pushed a commit that referenced this issue Jul 18, 2023
Adds the `get` function for maps for string and large_string to
primitive types.

Further additions can support more types. See
#494 for task list

Testing:
* verified that the sample map data (with a largeutf8) produces results
as expected.
github-merge-queue bot pushed a commit that referenced this issue Jul 21, 2023
Uses get index kernels to simplify evaluator types. Supports
`Boolean/String/Primitive` types for `get` on maps.

Part of #494
github-merge-queue bot pushed a commit that referenced this issue Jul 27, 2023
Adds type inference support for lists and adds just the `index`
function.

Further additions: #494
@jordanrfrazier
Copy link
Collaborator Author

jordanrfrazier commented Jul 28, 2023

Map and list types are not displayed correctly in the schema (see readings)
Screen Shot 2023-07-28 at 11 11 34 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant