Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use group_names when not needed #5

Closed
wants to merge 7 commits into from

Conversation

vpiserchia
Copy link

Remove usage of group_names to be coherent with other install scripts

@amirhmoradi
Copy link

@vpiserchia I find your PR very useful, thanks for the great work.
IMHO: It would be better and easier to validate a merge if different features where PR'ed separately.

For example:
PR1: renaming vars (proxy_port --> kasm_proxy_port...)
PR2: adding the single/multi install options
PR3: Moving install tasks around
PR4: changing the way group_names are identified
and so on.

Thanks.

@vpiserchia
Copy link
Author

@amirhmoradi I'll follow your instruction and this approach:

PR1: renaming vars (proxy_port --> kasm_proxy_port...)
PR2: adding the single/multi install options
PR3: Moving install tasks around
PR4: changing the way group_names are identified

For each of them I'll create a Issue to like the PR against. I hope this helps to track down the changes
br,
vito

@vpiserchia
Copy link
Author

vpiserchia commented Dec 16, 2024

Following @amirhmoradi suggestion this PR will be closed in favor of more self-contained ones

@vpiserchia
Copy link
Author

vpiserchia commented Dec 16, 2024

Following @amirhmoradi suggestion this PR will be closed in favor of more self-contained ones

@vpiserchia vpiserchia closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants