Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace current oldschnorr with the BIP340 schnorr variant #1028

Closed
elichai opened this issue Nov 11, 2020 · 0 comments
Closed

Replace current oldschnorr with the BIP340 schnorr variant #1028

elichai opened this issue Nov 11, 2020 · 0 comments
Assignees
@elichai
Labels
breaking-consensus consensus
Milestone
Testnet

Comments

@elichai
Copy link
Member

elichai commented Nov 11, 2020

Schnorr functions have no standardization.
We currently use some flavor that is taken from a somewhat old Bitcoin implementation, and other projects work on other flavors.

However, the implementation of Schnorr in the Bitcoin community has evolved throughout the years, to provide better security and performance.
It is therefore recommended that we adopt the most up-to-date Bitcoin implementation.
Besides being more secure and effective, it will also allow for easier implementation of Kaspa in other languages.
@elichai elichai added this to the Testnet milestone Nov 11, 2020
@elichai elichai self-assigned this Nov 11, 2020
@elichai elichai mentioned this issue Nov 11, 2020
Open
This was referenced Nov 30, 2020
Merged
Merged
svarogg pushed a commit that referenced this issue Dec 1, 2020
@elichai
[#1028] Replace oldschnorr with the BIP340 schnorr variant (#1165)
f1c6df4 
* Update go-secp256k1 to v0.0.3

* Update the txscript engine to support only 32 bytes pubkeys

* Update the txscript engine tests

* Update txscript/sign.go to use the new Schnorr KeyPair API

* Update txscript sign_test to use the new schnorr

* Update sigcache tests to use new schnorr pubkey

* Update integration tests to use the new txscript and new schnorr pubkey
@elichai elichai closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elichai elichai

Labels
breaking-consensus consensus
Projects
None yet
Milestone
Testnet
Development

No branches or pull requests
2 participants
@elichai and others