-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--rpclisten-borsh/json should support ip only like --grpclisten #402
Comments
For The string parsing logic in
The work is focused on the NOTE: Make sure that if only the IP is passed that you use the default port for the given network. Mainnet, testnet, simnet, devnet may have different default ports. |
I have drafted a PR for this issue, but forgot to include a reference in the commit #439 |
…spanet#439) * Add support for IP only for --rpclisten-borsh/json * Fix cehck complaints
commit 6a56461 Author: Maxim <59533214+biryukovmaxim@users.noreply.github.com> Date: Tue Jun 18 18:09:29 2024 +0300 Implement PSKT(Partially Signed Kaspa Transaction) (kaspanet#481) * initial support of pskt: supported roles: creator, constructor, updater, signer roles * add builder * handle combine errors * finalize * extractor * chore: typo * style: fmt * expose txid to global * chore: change version * feat: serde for optional bytes * feat: impl (de)serialization * style: fmt * add example, fixes * style: fmt * style: clippy * rollback unrelated changes * psbt -> pskt * refactor: avoid copy-paste by using recursion * docs: add description of roles commit a797e1e Author: George Bogodukhov <gvbgduh@gmail.com> Date: Mon Jun 17 15:50:16 2024 +1000 Add support for IP only for --rpclisten-borsh/json (kaspanet#402) (kaspanet#439) * Add support for IP only for --rpclisten-borsh/json * Fix cehck complaints
…spanet#439) * Add support for IP only for --rpclisten-borsh/json * Fix cehck complaints
This has been implemented in one of the merged PRs. Closing. |
kaspad supports specifying --rpclisten=0.0.0.0 for listening on all interfaces on default network port.
However, it doesn't support the same for --rpclisten-borsh and --rpclisten-json, even though the --help text specifies it as optional and is identical for the three:
The text was updated successfully, but these errors were encountered: