Fixes a bug with deleting level relations during pruning #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsutton
force-pushed
the
prune-fixes
branch
from
913d504
to
2f77b93
Compare
D-Stacks
approved these changes
Jun 22, 2023
tiram88
reviewed
Jun 23, 2023
michaelsutton
force-pushed
the
prune-fixes
branch
from
3813c5f
to
b46f6a2
Compare
tiram88
approved these changes
Jun 23, 2023
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* compile-time safety for detecting batch writer * reproduce zero cache delete bug with a simple test * refactor and use staging relations store for delete_level_relations algo * comments * remove trait duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a pruning-processor bug which can be easily reproduced with zero-cache sizes but is extremally rare if cache sizes are normal (though nonetheless can happen with some probability).
The bug is fixed by using a staging relations store for the delete operation. Required slightly refactoring the current
StagingRelationsStorein order to fit all use cases