gRPC server enhancements #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsutton
approved these changes
Oct 30, 2023
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* Identify connections to gRPC server with Uuids * Add concurrent request and subscription handlers to the connection to the gRPC server * On shutdown clear services from core and async runtime * Use tonic v0.10.x * Make `Notifier` sync channel available to integration tests * Fix tokio test runtime in daemon integration tests * Remove links from Connection & ConnectionHandler to Manager * Stop gRPC server forcefully on shutdown timeout * Add a gRPC client-server sanity check test * Lint * Reduce sleep time * Refactor gRPC client-server test * Add a gRPC client-server notifications test * Allocate only one thread to tokio test runtime of all daemon integration tests * Handle legacy virtual hash in `EstimateNetworkHashesPerSecond` RPC method * Make `subscribe` fn resistant to a theoretical race-condition * Ignore duplicated subscriptions * Add notify requests to Scope conversions * Unify subscription handler logic (one exception) * Fix meta * Fix typos * Add a gRPC payload ops enum * Replace `RpcApiOps` with `KaspadPayloadOps` in gRPC client * Replace `RpcApiOps` with `KaspadPayloadOps` in gRPC server * Add a macro building a gRPC server interface * Give request handlers payload op specific methods * Fix doc * Working GetMetrics method in gRPC client & server * Remove obsolete `RpcApiOps::Notification` * Remove `KaspadPayloadOps::is_subscription()` * Change GetMetrics server time type to u64 * Strictly correlate interface method set to KaspadPayloadOps variant set * Set gRPC server shutdown timeout to 1 second * Update tonic, prost & h2 to the latest versions * Move the connection routing logic inside the request receive loop, saving a lock * Make gRPC logs more consistent * Disconnect the client if the outgoing route gets full * Ignore oneshot send potential error * Polish logs * Refactor "not implemented" error building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the gRPC server with: