Lock wasm-bindgen version due to upstream compatibility issues #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiram88
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream wasm-bindgen developers have added
TryFrom<JsValue>for all wasm-bindgen ABI-bound Rust structs (rustwasm/wasm-bindgen#3554) which came in with the0.2.88update and broke all ourTryFrom<JsValue>conversion implementations. This PR freezes wasm-bindgen to the last viable version0.2.87until a solution is determined (whether upstream will consider reverting or we decide to create different traits for handling ABI object conversions). In the meantime, I have filed an issue rustwasm/wasm-bindgen#3685Updating
Cargo.lockcan result in the patch version update for wasm-bindgen, resulting in broken builds. This PR prevents this from happening.(This PR also updates few dependency versions and removes
Cargo.lockthat seems to have been accidentally committed in thekaspa-addressescrate folder)