-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/indexed db transaction store #392
Merged
aspect
merged 20 commits into
kaspanet:master
from
elertan:feat/indexed-db-transaction-store
Jan 18, 2024
Merged
Feat/indexed db transaction store #392
aspect
merged 20 commits into
kaspanet:master
from
elertan:feat/indexed-db-transaction-store
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e' into feat/indexed-db-transaction-store
Fixed clippy warnings |
aspect
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for implementing this. This is a great help.
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 20, 2024
* Add indexed db dependencies * Implementation progress for load_single * progress idb transaction store * use `Arc<Inner>` pattern * implementing try from jsvalue for types to be stored in idb * try from js value for utxo record * remove manual parsing and use borsh data to deserialize * indexdb progress * indexdb store and load multiple * indexdb remove, store tx note, store tx metadata * Add encryptable to transaction record for jsvalue * Remove logs * unnecessary import removed * Move from/to js value to idb implementation itself * fix some of the clippy warnings * fix all clippy warnings --------- Co-authored-by: aspect <anton.yemelyanov@gmail.com>
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 23, 2024
* Add indexed db dependencies * Implementation progress for load_single * progress idb transaction store * use `Arc<Inner>` pattern * implementing try from jsvalue for types to be stored in idb * try from js value for utxo record * remove manual parsing and use borsh data to deserialize * indexdb progress * indexdb store and load multiple * indexdb remove, store tx note, store tx metadata * Add encryptable to transaction record for jsvalue * Remove logs * unnecessary import removed * Move from/to js value to idb implementation itself * fix some of the clippy warnings * fix all clippy warnings --------- Co-authored-by: aspect <anton.yemelyanov@gmail.com>
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 24, 2024
* Add indexed db dependencies * Implementation progress for load_single * progress idb transaction store * use `Arc<Inner>` pattern * implementing try from jsvalue for types to be stored in idb * try from js value for utxo record * remove manual parsing and use borsh data to deserialize * indexdb progress * indexdb store and load multiple * indexdb remove, store tx note, store tx metadata * Add encryptable to transaction record for jsvalue * Remove logs * unnecessary import removed * Move from/to js value to idb implementation itself * fix some of the clippy warnings * fix all clippy warnings --------- Co-authored-by: aspect <anton.yemelyanov@gmail.com>
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* Add indexed db dependencies * Implementation progress for load_single * progress idb transaction store * use `Arc<Inner>` pattern * implementing try from jsvalue for types to be stored in idb * try from js value for utxo record * remove manual parsing and use borsh data to deserialize * indexdb progress * indexdb store and load multiple * indexdb remove, store tx note, store tx metadata * Add encryptable to transaction record for jsvalue * Remove logs * unnecessary import removed * Move from/to js value to idb implementation itself * fix some of the clippy warnings * fix all clippy warnings --------- Co-authored-by: aspect <anton.yemelyanov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indexed db transaction store implementation except for the
load_range
function.Still needs some good testing, mostly on the deserialisation process to ensure this functions as expected (so
load_single
.load_multiple
).Same goes for
remove
, but this is more likely to work properly.store_transaction_note
andstore_transaction_metadata
will most likely work properly whenload_single
/load_multiple
work as well, since it relies on similar logic.