Add "last known good" cache for virtual state #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michaelsutton
commented
Jan 18, 2024
michaelsutton
commented
- Optimizes many frequent P2P operations which now don't require waiting for the virtual store lock
- Improves responsiveness of RPC get metrics call
…unt for the headers phase)
…ing mempool size
…te dep on consensus
coderofstuff
requested changes
Jan 21, 2024
--------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com>
coderofstuff
approved these changes
Jan 21, 2024
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 22, 2024
* make a better estimation of header count (during IBD this will now count for the headers phase) * rpc service responsiveness: use `transaction_count_sample` for inferring mempool size * use counters snapshot * introduce last known good virtual state cache * move processing counters to consensus core and remove rpc service crate dep on consensus * extract consensus stats to a single call * turn some consensus session calls into non-async + fix get_block_dag_info_call * use saturating_sub instead of checked_sub + unwrap_or_default * use join over all async calls --------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com> --------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com>
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 23, 2024
* make a better estimation of header count (during IBD this will now count for the headers phase) * rpc service responsiveness: use `transaction_count_sample` for inferring mempool size * use counters snapshot * introduce last known good virtual state cache * move processing counters to consensus core and remove rpc service crate dep on consensus * extract consensus stats to a single call * turn some consensus session calls into non-async + fix get_block_dag_info_call * use saturating_sub instead of checked_sub + unwrap_or_default * use join over all async calls --------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com> --------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com>
|
In summary, this pull request is all about making P2P operations more efficient by removing the need for waiting on virtual store locks. Simultaneously, it aims to improve the responsiveness of the RPC get metrics call, providing faster access to important system metrics. These optimizations contribute to an overall enhancement of system performance and responsiveness. |
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 24, 2024
* make a better estimation of header count (during IBD this will now count for the headers phase) * rpc service responsiveness: use `transaction_count_sample` for inferring mempool size * use counters snapshot * introduce last known good virtual state cache * move processing counters to consensus core and remove rpc service crate dep on consensus * extract consensus stats to a single call * turn some consensus session calls into non-async + fix get_block_dag_info_call * use saturating_sub instead of checked_sub + unwrap_or_default * use join over all async calls --------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com> --------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com>
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* make a better estimation of header count (during IBD this will now count for the headers phase) * rpc service responsiveness: use `transaction_count_sample` for inferring mempool size * use counters snapshot * introduce last known good virtual state cache * move processing counters to consensus core and remove rpc service crate dep on consensus * extract consensus stats to a single call * turn some consensus session calls into non-async + fix get_block_dag_info_call * use saturating_sub instead of checked_sub + unwrap_or_default * use join over all async calls --------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com> --------- Co-authored-by: coderofstuff <114628839+coderofstuff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.