Fix rustc 1.77 issues and lints #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix seal macro hash error due to rustc 1.77 fix all rustc 1.77 lints
biryukovmaxim
suggested changes
Mar 26, 2024
| @@ -56,7 +56,7 @@ impl std::fmt::Display for AccountId { | |||
| } | |||
| } | |||
|
|
|||
| seal! { 0xa7a4, { | |||
| seal! { 0x544d, { | |||
There was a problem hiding this comment.
Since it only works with version 1.77 we have to introduce msrv equals 1.77 in manifest files
There was a problem hiding this comment.
MSRV added: ad701e1
|
|
||
| pub struct SessionReadGuard<'a>(RfRwLockReadGuard<'a>); | ||
| pub struct SessionReadGuard<'a>(pub RfRwLockReadGuard<'a>); |
There was a problem hiding this comment.
Did this change occur due to inter?
If so I would suggest to suppress it instead of making the field public
michaelsutton
previously approved these changes
Mar 26, 2024
michaelsutton
previously approved these changes
Mar 26, 2024
coderofstuff
previously approved these changes
Mar 26, 2024
|
it doesn't work properly |
propagated |
biryukovmaxim
approved these changes
Mar 26, 2024
coderofstuff
approved these changes
Mar 26, 2024
This was referenced Mar 26, 2024
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* remove BorshSchema due to rustc 1.77 issues * fix seal macro hash error due to rustc 1.77 * fix all rustc 1.77 lints * add MSRV to `Cargo.toml` * suppress lints instead of making fields public * propagate `package.rust-version` to all workspace crates
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jul 12, 2024
* remove BorshSchema due to rustc 1.77 issues * fix seal macro hash error due to rustc 1.77 * fix all rustc 1.77 lints * add MSRV to `Cargo.toml` * suppress lints instead of making fields public * propagate `package.rust-version` to all workspace crates
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jul 17, 2024
* remove BorshSchema due to rustc 1.77 issues * fix seal macro hash error due to rustc 1.77 * fix all rustc 1.77 lints * add MSRV to `Cargo.toml` * suppress lints instead of making fields public * propagate `package.rust-version` to all workspace crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates #438 (unfortunately I can't merge this due to other lint errors, so if this merged #438 should be closed)