Code

Replace by fee on mempool#499

Code

Merged

michaelsutton merged 30 commits intokaspanet:devkaspanet/rusty-kaspa:devfrom Kaffidev:replace-by-feeKaffidev/rusty-kaspa:replace-by-feeCopy head branch name to clipboardJul 22, 2024

+1,455-308

Commits

Commits on Jul 1, 2024

• Replace by fee on mempool with tests

  KaffinPX

  committed
  621ab30

• Add a custom RemovalReason -- ReplacedByFee

  KaffinPX

  committed
  28c2ecc

Commits on Jul 4, 2024

• Let MinerManager handle replace by fee (RBF) for RPC and P2P

  tiram88

  committed
  1430039

• Refines success conditions and process of RBF policies

  tiram88

  committed
  7ef25be

Commits on Jul 5, 2024

• Add an RPC submit_transaction_replacement method

  tiram88

  committed
  4c83d0f

• fix fmt

  tiram88

  committed
  bf662d7

• Fix CLI Build WASM32 error

  tiram88

  committed
  13676ef

• Avoid breaking wRPC

  tiram88

  committed
  3b4fde9

Commits on Jul 6, 2024

• Extend some tests coverage to all priority, orphan & RBF policy combinations

  tiram88

  committed
  d6970f8

Commits on Jul 8, 2024

• Let RBF fail early or at least before checking transaction scripts in consensus

  tiram88

  committed
  33b2295

• Cleaning

  tiram88

  committed
  d95dfdb

• More cleaning

  tiram88

  committed
  8cce2b4

Commits on Jul 9, 2024

• Use contextual instead of compute mass in RBF eviction rule

  tiram88

  committed
  ba3b75e

• Avoid collision with another PR

  tiram88

  committed
  31b20a7

• Avoid collision with another PR (2)

  tiram88

  committed
  ce2f76d

• Extended test coverage of RBF

  tiram88

  committed
  335f3d6

• Extended test coverage of RBF (2)

  tiram88

  committed
  4139e14

Commits on Jul 11, 2024

• Rename TransactionBatchValidationArgs to TransactionValidationBatchArgs

  tiram88

  committed
  e4e2355

• Add comments

  tiram88

  committed
  9147abb

• Assert instead of condition

  tiram88

  committed
  96df37e

Commits on Jul 12, 2024

• Add an RbfPolicy parameter to mining manager tx validate_and_insert_... fns

  tiram88

  committed
  0cd7c10

• Infer RBF policy from unorphaned transaction

  tiram88

  committed
  b6730af

• Apply the RBF policy to all orphan-related cases

  tiram88

  committed
  6971302

Commits on Jul 22, 2024

• In Rbf allowed mode, check feerate threshold vs all double spends (i.e., compare to the max)

  michaelsutton

  committed
  9fbd741

• Minor hashset optimization

  michaelsutton

  committed
  1fcb264

• Rename: fee_per_mass -> feerate

  michaelsutton

  committed
  4679a8d

• Use rbf policy arg for post processing step as well

  michaelsutton

  committed
  8093ef6

• Renames and comments

  michaelsutton

  committed
  dc46102

• Relaxation: fail gracefully if rbf replaced tx is missing (also fixes an edge case where mempool duplication resulted in this scenario)

  michaelsutton

  committed
  49d584b

• Tx id is appended by the caller anyway

  michaelsutton

  committed
  c4ee735