Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new gRPC methods to use camel case (non-breaking change) #560

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Fix new gRPC methods to use camel case (non-breaking change) #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions rpc/grpc/core/proto/rpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// Having received a RequestMessage, (wrapped in a KaspadMessage) the RPC server will respond with a
// ResponseMessage (likewise wrapped in a KaspadMessage) respective to the original RequestMessage.
//
// **IMPORTANT:** This API is a work in progress and is subject to break between versions.
//
syntax = "proto3";
package protowire;
Expand Down Expand Up @@ -897,7 +896,7 @@ message GetSyncStatusResponseMessage{
}

message GetDaaScoreTimestampEstimateRequestMessage {
repeated uint64 daa_scores = 1;
repeated uint64 daaScores = 1;
}

message GetDaaScoreTimestampEstimateResponseMessage{
Expand All @@ -908,7 +907,7 @@ message GetDaaScoreTimestampEstimateResponseMessage{
message RpcFeerateBucket {
// Fee/mass of a transaction in `sompi/gram` units
double feerate = 1;
double estimated_seconds = 2;
double estimatedSeconds = 2;
}

// Data required for making fee estimates.
Expand All @@ -918,28 +917,28 @@ message RpcFeerateBucket {
// taking the transaction mass and multiplying it by feerate: `fee = feerate * mass(tx)`
message RpcFeeEstimate {
// Top-priority feerate bucket. Provides an estimation of the feerate required for sub-second DAG inclusion.
RpcFeerateBucket priority_bucket = 1;
RpcFeerateBucket priorityBucket = 1;

// A vector of *normal* priority feerate values. The first value of this vector is guaranteed to exist and
// provide an estimation for sub-*minute* DAG inclusion. All other values will have shorter estimation
// times than all `low_bucket` values. Therefor by chaining `[priority] | normal | low` and interpolating
// times than all `lowBucket` values. Therefor by chaining `[priority] | normal | low` and interpolating
// between them, one can compose a complete feerate function on the client side. The API makes an effort
// to sample enough "interesting" points on the feerate-to-time curve, so that the interpolation is meaningful.
repeated RpcFeerateBucket normal_buckets = 2;
repeated RpcFeerateBucket normalBuckets = 2;

// A vector of *low* priority feerate values. The first value of this vector is guaranteed to
// exist and provide an estimation for sub-*hour* DAG inclusion.
repeated RpcFeerateBucket low_buckets = 3;
repeated RpcFeerateBucket lowBuckets = 3;
}

message RpcFeeEstimateVerboseExperimentalData {
uint64 mempool_ready_transactions_count = 1;
uint64 mempool_ready_transactions_total_mass = 2;
uint64 network_mass_per_second = 3;
uint64 mempoolReadyTransactionsCount = 1;
uint64 mempoolReadyTransactionsTotalMass = 2;
uint64 networkMassPerSecond = 3;

double next_block_template_feerate_min = 11;
double next_block_template_feerate_median = 12;
double next_block_template_feerate_max = 13;
double nextBlockTemplateFeerateMin = 11;
double nextBlockTemplateFeerateMedian = 12;
double nextBlockTemplateFeerateMax = 13;
}

message GetFeeEstimateRequestMessage {
Expand Down