-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mining Rule Engine Scaffolding and Sync Rate Rule implementation #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2025
Closed
someone235
requested changes
Mar 23, 2025
someone235
previously approved these changes
Mar 23, 2025
- monitor sync state and update anything that cares about is_sycned to use the updated rules - sync rate rule: allow mining if sync rate is below threshold and finality point is recent Move most is_nearly_synced logic to mining_rule_engine - instantiate Hub in daemon - Reverse the dependency of flow context and MRE - remove the async_is_nearly_synced consensus api - add get_sink_daa_score_timestamp consensus API Move is_nearly_synced logic from params to rule engine
- Make it not depend on sync rate rule
f2311b6
to
1254a28
Compare
someone235
previously approved these changes
Mar 23, 2025
michaelsutton
requested changes
Mar 23, 2025
michaelsutton
approved these changes
Mar 24, 2025
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the PR at #634 into multiple parts, this is part 1/3 with
Mining Rule
Sync Rate Rule
Goal:
Allow mining even when the sink timestamp is outdated if the sync rate falls below a threshold
Rule:
Allow mining even if the sink timestamp is outdated. Accept blocks in Submit Block RPC.
Metric:
max(delta.body_count, delta.header_count)
interval_in_millis / target_time_per_block
Definitions:
Trigger:
Recovery: