Account for block styles with relative CSS URLs #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kasparsd
commented
Sep 10, 2024
kasparsd
commented
- Remove async JS script loader for external scripts because we can't reliably determine if the script is external.
- Update the asset file path extractor to support paths relative to ABSPATH as used by block assets, for example.
kasparsd
commented
Sep 10, 2024
| return false; | ||
| } | ||
| // Inline block scripts are sometimes relative URLs. | ||
| if ( 0 === strpos( $item_url, '/' ) ) { |
There was a problem hiding this comment.
This will return false positives for URLs without protocol, though such as //example.com/....
kasparsd
commented
Sep 10, 2024
|
|
||
| $script_relative_path = $this->get_asset_relative_path( $handle ); | ||
|
|
||
| if ( ! $script_relative_path ) { |
There was a problem hiding this comment.
This wasn't correctly determining if the asset has URL and is not part of the generated bundles. Need to make it more deterministic if we want to add it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.