Fix issue that caused modals to stay on screen if they were released …

…from memory (#326)
kasper · Mar 24, 2023 · 7f9b158 · 7f9b158
1 parent 66e1772
commit 7f9b158
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,6 +25,7 @@ Release: dd.mm.yyyy
 
 - Fix issue that caused modals not to adjust to a custom weight if no font was provided ([#314](https://github.com/kasper/phoenix/issues/314)).
 - Fix issue that caused input modals not to have a fixed width ([#324](https://github.com/kasper/phoenix/issues/324)).
+- Fix issue that caused modals to stay on screen if they were released from memory ([#326](https://github.com/kasper/phoenix/issues/326)).
 
 ### API
 

diff --git a/Phoenix/PHModalWindowController.m b/Phoenix/PHModalWindowController.m
@@ -66,6 +66,7 @@ - (instancetype)init {
 #pragma mark - Deallocing
 
 - (void)dealloc {
+    [super close];
     [self removeObserverForKeyPaths:[PHModalWindowController keyPaths]];
     [[NSNotificationCenter defaultCenter] removeObserver:self name:PHContextWillLoadNotification object:nil];
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,6 +25,7 @@ Release: dd.mm.yyyy @@
     - Fix issue that caused modals not to adjust to a custom weight if no font was provided ([#314](https://github.com/kasper/phoenix/issues/314)).
     - Fix issue that caused input modals not to have a fixed width ([#324](https://github.com/kasper/phoenix/issues/324)).
+    - Fix issue that caused modals to stay on screen if they were released from memory ([#326](https://github.com/kasper/phoenix/issues/326)).
     ### API
@@ Expand Down @@