Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.others({ screen: window.screen() }) did not work as expected #116

Closed
alswl opened this issue Jul 13, 2016 · 2 comments
Closed

window.others({ screen: window.screen() }) did not work as expected #116

alswl opened this issue Jul 13, 2016 · 2 comments
Assignees
@kasper
Labels
bug
Milestone
2.2.1

Comments

@alswl
Copy link
Contributor

alswl commented Jul 13, 2016

  • Version: Version 2.2 (33)
  • macOS: 10.11.5 (15F34)

window.others({ screen: window.screen() }) did not works as expected.

It return the windows of current two displays, not only current screen.

Now I fixed with the configuration.

alswl/.oOo.@31bad33#diff-c242c5e0ce099258ad80f34cfd202858L150
@kasper kasper added the bug label Jul 13, 2016
@kasper kasper added this to the 2.2.1 milestone Jul 13, 2016
@kasper kasper self-assigned this Jul 13, 2016
@kasper
Copy link
Owner

kasper commented Jul 13, 2016

@alswl Terribly sorry about this too!

kasper added a commit that referenced this issue Jul 13, 2016
@kasper
Fix issue that prevented Window#others(...) returning the correct win…
b62f6db 
…dows based on the screen optional (#116)
@kasper
Copy link
Owner

kasper commented Jul 13, 2016

Fixed. Thanks for the report!

@kasper kasper closed this as completed Jul 13, 2016
alswl added a commit to alswl/.oOo. that referenced this issue Jul 13, 2016
@alswl
fix:
f071255 
kasper/phoenix#118
kasper/phoenix#116
kasper/phoenix#117
alswl added a commit to alswl/.oOo. that referenced this issue May 18, 2022
@alswl
fix:
5adff83 
kasper/phoenix#118
kasper/phoenix#116
kasper/phoenix#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasper kasper

Labels
bug
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@alswl @kasper