Group seeds by top level model + plus data tables #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're moving further away from Fixtures 1-1 where a file maps to one table. We started this by allowing updates to multiple models in one file, but now we're adding an additional conceptual layer to help reveal apps' systems. We'll be recommending that apps have files for their top-level model: their account concept. Which could be Account, Team, Organization, etc. This way, we still get the slice of the world that fixtures are good at, but way easier to understand how things connect because they're all hanging off that top-level model. I'm also recommending a `test/seeds/data` folder for any clear data-tables that apps need, which also contain production data.
Comments are usually attached to posts and their user creator's, whereas plans are tables we want to ensure are in the database from the get-go. I'm also swapping our test check to `after_save` to prevent a silent failure where the record is already in the DB and then won't trigger `after_create`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're moving further away from Fixtures 1-1 where a file maps to one table.
We started this by allowing updates to multiple models in one file, but now we're adding
an additional conceptual layer to help reveal apps' systems.
We'll be recommending that apps have files for their top-level model: their account concept.
Which could be Account, Team, Organization, etc.
This way, we still get the slice of the world that fixtures are good at, but way easier to
understand how things connect because they're all hanging off that top-level model.
I'm also recommending a
test/seeds/datafolder for any clear data-tables that apps need, which also contain production data.