Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: replacing previous import ‘ggplot2::%+%’ by ‘survminer::%+%’ when loading #200

Closed
MarcinKosinski opened this issue Apr 24, 2017 · 4 comments

Comments

@MarcinKosinski
Copy link
Contributor

Expected behavior

One use a survminer as a dependent/imported package in his package without warnings.

Actual behavior

I get the following warning during the CHECK

Warning: replacing previous import ‘ggplot2::%+%’ by ‘survminer::%+%’ when loading 'RTCGA'

for all 3 platforms at Bioconductor
http://bioconductor.org/checkResults/release/bioc-LATEST/RTCGA/

Question

Is the %+% actually a good idea to be used in the survminer and ggplot2? This issue is similiar to the #199 and I think can be resolved with changing the name from %+% to something like %++%.

';..;'

@kassambara
Copy link
Owner

I will change the %+% to %++%

@MarcinKosinski
Copy link
Contributor Author

By the way, in which places this operator was used?

@kassambara
Copy link
Owner

It's used in add_ggsurvplot.R file

kassambara added a commit that referenced this issue Apr 27, 2017
@kassambara
Copy link
Owner

fixed now:-)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants