Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about ggcoxadjustedcurves #229

Closed
kassambara opened this issue Jun 15, 2017 · 4 comments
Closed

Question about ggcoxadjustedcurves #229

kassambara opened this issue Jun 15, 2017 · 4 comments

Comments

@kassambara
Copy link
Owner

Comment from a STHDA visitor (http://www.sthda.com/english/wiki/survminer-0-3-0)

@pbiecek, what do you think about the comment below?

Hi,

Keep up the good work! I wanted to ask a question regarding the function ggadjustedcurve(). From my understanding, this function works by predicting survival probabilties of each individual and then these survival probabilities are averaged by strata (ex. sex). I do not believe this is what is referenced by the "Terry M Therneau (2015); Adjusted survival curves" article. The way it is currently done results in different covariate distributions for each strata. For example, females will have a set of covariate values unique to them, whereas males will have a set of covariate values unique to them - I do not believe this is "adjusted". Ideally, we'd want both covariate distribution to be identical and the only factor changing would be sex - allowing us to talk about how the factor of interest (in isolation) is impacting survival, adjusted for other covariates. Can you please verify if the way it is done in the ggadjustedcuve() is different than the one referenced on the website? If I am wrong, please forgive me but I was speaking to one of my superiors and he pointed out that the way it is currently calculated may be just the "Average" curve and not "adjusted" curve.

Thanks alot

@pbiecek
Copy link
Contributor

pbiecek commented Jun 16, 2017

Thanks, will check this on Monday

@pbiecek
Copy link
Contributor

pbiecek commented Jun 22, 2017

IMHO this issue is solved with #233

@kassambara
Copy link
Owner Author

I'm amazed by the update you've done in the ggadjustedcurves() function, thank you very much.

I think that we can close this issue.

@brant01
Copy link

brant01 commented Aug 6, 2017

First, thank you for this incredibly valuable package. I have used it extensively. I am having a problem with ggcoxadjustedcurves with large data sets. I can run the coxph, but when I try to make an adjusted curve I get an error that data must be a dictionary (n = 4000). If I take a random sample of 100 from this dataset and do the same thing, I do not get this error. Is there an issue with inputting large cox models into ggcoxadjusted curves? I have looked extensively and cannot find a similar error report.

Thanks again for this package and all of the work that went into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants