add option for smooth survival curve in ggsurvplot_df #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like AppVeyor isn't running. |
|
It would be nice if I could get some feedback here. Is there any chance that this PR will be accepted? I am ok with it not being accepted, but I need to know so I can prepare my course. |
|
Thank you @HeidiSeibold for your contribution and sorry for the delay. I will merge this! |
|
Your conntribution in the vignette is also very welcome, thnaks! |
kassambara
added a commit
that referenced
this pull request
Jul 24, 2018
|
Thanks @kassambara! Should I add to an existing vignette or should there be an additional vignette? |
|
I think that it's better to create an additional vignette for plotting survreg model... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a possible solution for issue #276. It is just a suggestion. So no pressure.
It is just a feature I really need for my survival course, where I want to use this package and I need to be able to plot survreg models.
I included an example and would be happy to also include something in the vignette if you want.