allow Inf and near 0 CIs to plot in ggforest #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschauner
commented
Apr 19, 2022
| conf.high <- conf.low <- estimate <- NULL | ||
| stopifnot(inherits(model, "coxph")) | ||
|
|
||
| # get data and variables/terms from cox model | ||
| data <- .get_data(model, data = data) | ||
| data <- survminer:::.get_data(model, data = data) |
There was a problem hiding this comment.
survminer::: should be removed
rschauner
commented
Apr 19, 2022
| var <- names(terms)[i] | ||
| #### ADD with = FALSE because error during testing |
There was a problem hiding this comment.
Might be a data.table version thing, data.table version is 1.14.0
rschauner
commented
Apr 19, 2022
| toShowExpClean <- toShowExpClean[nrow(toShowExpClean):1, ] | ||
|
|
||
| # get min/max CI values to place where Inf would be |
There was a problem hiding this comment.
get min/max CI values and replace near 0 and Inf values with those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to fix my issue (#570). During axis ticks generation, if there are any near 0 or Inf values, they are set to the min and max values across all confidence intervals.
Things I thought would be nice but didn't know how to include.
I was planning on just adding that in Adobe Illustrator, but, that might be something that could be done by ggplot2.
Apologies about all the changes, my linter in Visual Studio Code seemed to take over