Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore RunData from state.json #62

Merged
merged 2 commits into from
May 9, 2023
Merged

Restore RunData from state.json #62

merged 2 commits into from
May 9, 2023

Conversation

eirrgang
Copy link
Collaborator

@eirrgang eirrgang commented May 9, 2023

First commit fixes the test. Second commit fixes the bug.

Fixes #61

@eirrgang eirrgang self-assigned this May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #62 (3e4b8f3) into main (51388b6) will increase coverage by 1.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   74.92%   76.30%   +1.38%     
==========================================
  Files           7        7              
  Lines         650      650              
  Branches      154      154              
==========================================
+ Hits          487      496       +9     
+ Misses        108      101       -7     
+ Partials       55       53       -2     
Impacted Files Coverage Δ
src/brer/run_data.py 79.03% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@peterkasson peterkasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@carolinedav carolinedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@eirrgang eirrgang merged commit 7b0262e into main May 9, 2023
@eirrgang eirrgang deleted the b61-state-restoration branch May 9, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State file not restored.
3 participants