This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Kanister profile #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdmanv
reviewed
Jun 13, 2018
| @@ -0,0 +1,5 @@ | |||
| dependencies: | |||
| - name: profile | |||
| version: 0.1.0 | |||
There was a problem hiding this comment.
This can't be templated, correct? What happens when we update the profile chart?
There was a problem hiding this comment.
from https://github.com/kubernetes/helm/blob/master/docs/helm/helm_dependency.md
The 'version' field should contain a semantic version or version range.
There was a problem hiding this comment.
something like version: =>0.1.0 should work
There was a problem hiding this comment.
|
To push it upstream you would have to bump chart version. Also @ntolia wanted to drop v form chart version |
|
Sure, Ill do that. What should I change the chart version to? |
|
closing since we have our chart repo added into https://hub.helm.sh/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Are we planning to move this chart to the kanister repo?