This repository has been archived by the owner on May 12, 2021. It is now read-only.
[RFC] Initial gRPC protocol for agent communication #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on hyperstart gRPC protocol and the discussion in hyperhq/runv#628 and kata-containers/runtime#2 Signed-off-by: Wang Xu <gnawux@gmail.com>
|
My only concern is the |
|
@laijs PTAL and if this looks good to you we'll merge. |
|
OK. Good start point. I add However, I am thinking if we should put some header for kata org itself. |
|
@gnawux Thanks for putting the right copyright, I appreciate. |
|
@sameo afaik we may have an additional header, such as But I don't know how it works in detail, I am not a lawyer as well. |
|
LGTM |
mcastelino
pushed a commit
to mcastelino/agent-1
that referenced
this pull request
Dec 6, 2018
virtio-mmio: Add support for the virtio-mmio driver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on hyperstart gRPC protocol and the discussion in hyperhq/runv#628 and
kata-containers/runtime#2