namespace: do not create path using rand. #279
Conversation
|
@jcvenegas: Thanks for reporting this issue. I have faced this issue multiple times in the past few days but thought it was some local config issue. Tested your patch on ppc64le. Worked fine. |
|
hit error: kata-containers/tests#361 |
jcvenegas
force-pushed
the
dont-call-rand
branch
from
b469ea3 to
046e8f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 43.27% 43.25% -0.02%
==========================================
Files 14 14
Lines 2244 2240 -4
==========================================
- Hits 971 969 -2
+ Misses 1141 1140 -1
+ Partials 132 131 -1
Continue to review full report at Codecov.
|
jcvenegas
force-pushed
the
dont-call-rand
branch
3 times, most recently
from
5d56420 to
65a1677
Compare
Using random char generation at early boot may slow the process due to low entropy. Also from kernel 4.14.36 rand call hangs due to low-entropy. Lets remove dependency on rand at early sandbox creation. Fixes: kata-containers#278 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas
force-pushed
the
dont-call-rand
branch
from
65a1677 to
57bf4e6
Compare
|
Good catch @jcvenegas! lgtm I am curious to know why we originally created a randomly-named ns though (which seems perfectly reasonable). |
|
I have retriggered the build again, I really want to merge this asap so that we can move forward with the latest kernel 4.14.51. In the meantime, we have to figure out how to give more entropy to the VM. |
Update to kernel to get latest fixes. Depends-on: github.com/kata-containers/agent#279 Fixes: kata-containers#420 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Using random char generation at early boot may slow the process due to
low entropy.
Also from kernel 4.14.36 rand call hangs due to low-entropy. Lets
remove dependency on rand at early sandbox creation.
Fixes: #278
Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com