Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgroup2: Support cgroup.kill #98

Closed
dcantah opened this issue Jan 8, 2023 · 0 comments · Fixed by #97
Closed

cgroup2: Support cgroup.kill #98

dcantah opened this issue Jan 8, 2023 · 0 comments · Fixed by #97
Labels
feature needs-review

Comments

@dcantah
Copy link

dcantah commented Jan 8, 2023 •
edited
Loading

In 5.14+ there exists a cgroup.kill that will send a SIGKILL to every process in the tree if written to (with a "1"). This would be useful for kata to avoid the freezing -> manually sending SIGKILL -> thawing process it does currently (same thing runc does at the moment).
dcantah added a commit to dcantah/cgroups-rs that referenced this issue Jan 8, 2023
@dcantah
cgroup2: Add Kill method

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
f10ff98 
Fixes: kata-containers#98

Add a Kill method for cgroups v2. This uses the new functionality in
kernels 5.14+ where writing to a cgroup.kill file will send a SIGKILL
to every process running in the cgroup. This would be useful for
kata to avoid freezing+manually sending SIGKILL+thawing process it
does currently to emulate runc's behavior.

Signed-off-by: Danny Canter <danny@dcantah.dev>
@dcantah dcantah mentioned this issue Jan 8, 2023
Merged
dcantah added a commit to dcantah/cgroups-rs that referenced this issue Jan 9, 2023
@dcantah
cgroup2: Add Kill method
29097b6 
Fixes: kata-containers#98

Add a Kill method for cgroups v2. This uses the new functionality in
kernels 5.14+ where writing to a cgroup.kill file will send a SIGKILL
to every process running in the cgroup. This would be useful for
kata to avoid freezing+manually sending SIGKILL+thawing process it
does currently to emulate runc's behavior.

Signed-off-by: Danny Canter <danny@dcantah.dev>
dcantah added a commit to dcantah/cgroups-rs that referenced this issue Jan 10, 2023
@dcantah
cgroup2: Add Kill method
0787832 
Fixes: kata-containers#98

Add a Kill method for cgroups v2. This uses the new functionality in
kernels 5.14+ where writing to a cgroup.kill file will send a SIGKILL
to every process running in the cgroup. This would be useful for
kata to avoid freezing+manually sending SIGKILL+thawing process it
does currently to emulate runc's behavior.

Signed-off-by: Danny Canter <danny@dcantah.dev>
Tim-Zhang added a commit to Tim-Zhang/cgroups-rs that referenced this issue Jan 11, 2023
@Tim-Zhang
release: v0.2.12
e845665 
To include patches kata-containers#91, kata-containers#94, kata-containers#98, kata-containers#99

Signed-off-by: Tim Zhang <tim@hyper.sh>
@Tim-Zhang Tim-Zhang mentioned this issue Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cgroup2: Add Kill method dcantah/cgroups-rs
1 participant
@dcantah